tricorder-observability / Starship

Starship: next-generation Observability platform built with eBPF+WASM

GNU Affero General Public License v3.0

162 stars 25 forks source link

reconnect gracefully for streaming #180

Closed feuyeux closed 1 year ago

feuyeux commented 1 year ago

Describe your changes

Issue

[x] If this PR fixes an issue, paste the link below https://github.com/tricorder-observability/Starship/issues/141

Test:

[ ] What tests are done for this PR None

oojimmy commented 1 year ago

@feuyeux hello, Any updates on this PR?

feuyeux commented 1 year ago

sorry for late, and thanks.

oojimmy commented 1 year ago

https://github.com/tricorder-observability/Starship/blob/main/src/agent/deployer/deployer.go#L150 these function have log.Fatalf, Maybe it need to change to log.Errorf

oojimmy commented 1 year ago

Thank you very much for your contribution. If you're interested in this project and would like to contribute further, please feel free to choose the task you want to do in the issues, and we look forward to your other PR. @feuyeux