tricorder-observability / Starship

Starship: next-generation Observability platform built with eBPF+WASM
GNU Affero General Public License v3.0
163 stars 23 forks source link

Helm charts release should not create tag #204

Closed nascentcore-eng closed 1 year ago

nascentcore-eng commented 1 year ago

The current situation, motivation for this task During helm chart release workflow, the releaser job creates a tag after the helm charts's version

We are moving towards manual tagging and automated trigger helm charts and container imagine release, so this behavior is not useful

Describe the solution Needs investigation

Describe alternatives considered None

Additional context None

nascentcore-eng commented 1 year ago

After some investigation, we concluded that it's not possible to have separate workflows, one for releasing container images, and the other for releasing helm charts; and yet at the same time tag pushed in the helm-charts release workflow further triggering the container images release workflow.

See https://github.com/orgs/community/discussions/27194

Using Personal Access Token is not an option (but indeed can achieve the right behavior).

So in the end we decide to just merge image release workflow and the helm-charts release workflow.