search

tricorder-observability / Starship

Starship: next-generation Observability platform built with eBPF+WASM
GNU Affero General Public License v3.0
163 stars 23 forks source link

Package wasi-sdk.tar.gz directly inside API Server image #225

Open nascentcore-eng opened 1 year ago

nascentcore-eng commented 1 year ago

Describe what should be done For https://github.com/tricorder-observability/Starship/issues/187, we should package wasi sdk tar.gz file directly inside API Server image, without untaring it before hand. In the current setup, directly packaging tar.gz results into an 340MB image file, without packaging, it's 880MB.

The size difference is large enough to consider this.

Also, it makes it easier to testing the code, as the untarring uses directory as output, and causes weird testing failures in https://github.com/tricorder-observability/Starship/issues/221

Describe alternatives considered None

Additional context None

nascentcore-eng commented 1 year ago

If we do this, we should just close https://github.com/tricorder-observability/Starship/issues/221

nascentcore-eng commented 1 year ago

If we do this, we can also get rid of the annoying warning in bazel build: WARNING: /home/yaxiong/Workspace/tricorder-observability/Starship/src/api-server/cmd/BUILD.bazel:37:8: output 'src/api-server/cmd/wasi-sdk-19.0' of //src/api-server/cmd:extract_wasi_sdk is a directory; dependency checking of directories is unsound

image