search

tricorder-observability / Starship

Starship: next-generation Observability platform built with eBPF+WASM
GNU Affero General Public License v3.0
164 stars 24 forks source link

Revamp API Server module management logic #45

Closed JaredTan95 closed 1 year ago

JaredTan95 commented 1 year ago

Describe the bug https://github.com/tricorder-observability/starship/blob/852be118c353b2e72ac609ee64a04afbd15f611f/src/api-server/grpc/deployer.go#L114

deployer will update the module's status when one of agent deploy success. It causes the left agents will not receive the deploy request.

Expected behavior All of the agents receive module deploy requests.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

Sub tasks

nascentcore-eng commented 1 year ago

https://tricorder.feishu.cn/wiki/wikcnVXHjFF1zHEqProyQRnHb0c

We have summarized the desired workflow in this doc. @JaredTan95 @jmzwcn @zh9310

feuyeux commented 1 year ago

It's would be better to setup a task queue machenism to solve both with the issue 150

oojimmy commented 1 year ago

API-server refactor have done in https://github.com/tricorder-observability/Starship/pulls?q=is%3Apr+is%3Aclosed+author%3Aowl-ltt+refactor%28api-server%29