search

tricorder-observability / Starship

Starship: next-generation Observability platform built with eBPF+WASM
GNU Affero General Public License v3.0
164 stars 24 forks source link

API Server's container info collector has a broken logic #60

Closed nascentcore-eng closed 1 year ago

nascentcore-eng commented 1 year ago

Describe the bug The watcher would write container info object directly over gRPC streaming channel to the agent. But when the gRPC streaming channel is closed, there is no way to inform the watcher to write a different agent. Or make it stop.

To Reproduce Just delete an agent, the API Server's previously-created watcher will continue to run, but always produces gRPC channel failure.

Expected behavior API Server should gracefully stops watcher, and waiting for the new watcher to be created for the restarted agent.

Screenshots image

Additional context None

nascentcore-eng commented 1 year ago

Add the commit that fixes this bug and close this issue.

jmzwcn commented 1 year ago

https://github.com/tricorder-observability/starship/commit/3c63b6293b8472da3802ea8224117692ebdbc26f