Closed yaoyaoio closed 1 year ago
Take a look at the CI test failures, and see if you could fix them.
Run tools/cleanup.sh to fix some of the style issues and bazel build files issue.
The below are the failures in the CI pipeline.
ok. I fix these issues.
I have made changes according suggestions Please review and CI test.
The go file lacks license header. You'll need to run tools/cleanup.sh to add the license header
Starship's CI/CD setup on GitHub might prevent you from releasing a dev image, we'll fix them separately.
I think my last request is to think about adding an automated test.
I could not come up a plan to implement a simple automated test, because there is no readily available testing fixture (like a fake kubernetes and kubectl local environment).
But I think you can write a brief doc on how to verify the correctness of this feature.
Starship's CI/CD setup on GitHub might prevent you from releasing a dev image, we'll fix them separately.
https://github.com/tricorder-observability/starship/pull/99 fixed docker build and push issue, you can rebase main
branch to fix CI. @yaoyaoio
implement
Do you want me to implement a simple automated test to verify getting starship apiserver from kubernetes?
Yes, if it's possible to do that.
If it's very complicated to do, then don't bother, manual testing is fine.
Sorry I should’t have used merge.
Need to rebase on the main branch.
add: get apiaddress for kubernetes cluster.
I tested it on aliyun ack cluster.