Adding hint kwarg upon LightRay load to break degeneracy in new yt loader

trident-project / trident

A Synthetic Spectral Generation Suite

Other

21 stars 25 forks source link

Adding hint kwarg upon LightRay load to break degeneracy in new yt loader #181

Closed chummels closed 2 years ago

chummels commented 2 years ago

A recent change in yt (PR #3666) breaks trident when trident reloads a LightRay object into working memory. This one-line change provides a "hint" that breaks the degeneracy in Datasets types that yt is confused about, and allows Trident to continue working the way it used to.

This bug was discovered by @evaneschneider , so I'll let her comment on how well this fix works for her case.

evaneschneider commented 2 years ago

This fixes the issue.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 65115f20-f62e-457b-9def-1ddfb6578670

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.619%

Totals
Change from base Build 7b66a3d7-75dc-46c7-9e68-bd3e9afd5d95:	0.0%
Covered Lines:	1740
Relevant Lines:	2301

trident-project / trident

Adding hint kwarg upon LightRay load to break degeneracy in new yt loader #181

Pull Request Test Coverage Report for Build 65115f20-f62e-457b-9def-1ddfb6578670

💛 - Coveralls