tridentli / trident

Trident is a trusted and secure communication platform for enabling better communication between groups of trusted parties
https://trident.li
Apache License 2.0
20 stars 9 forks source link

Enhancement: Prohibit trustgroup administrators from changing members' profiles if users are sysadmin #132

Open teward opened 6 years ago

teward commented 6 years ago

During a pentest done against a Trident instance, it was observed that trustgroup administrators can change trustgroup members' profile data.

Whether this was initially supposed to be allowed or not, it should not be permitted for Trustgroup Administrators to change profile data for sysadmin level users. I propose that if a trustgroup administrator is attempting to change a system administrator's profile data that they get an error, and that only system administrators or the user themselves should be changing other sysadmins' profiles.