search

trieb-work / zoho-ts

Zoho Inventory, Invoice and Books Typescript library with several predefined functions
Apache License 2.0
13 stars 5 forks source link

Is 25 a hard limit or can we confirm even more with one API request to safe some zoho api requests? #13

Closed tilman closed 2 years ago

tilman commented 2 years ago

https://github.com/trieb-work/zoho-ts/blob/f86ffbdeb18566c6e130f8528d5f12fd5ccfb721/src/service/salesOrder.ts#L149

If it is a hard limit please close the issue otherwise I would suggest to increase it to at least 100 and make the option configurable via an optional argument like this:

public async confirm(ids: string[], chunkSize: number = 100): Promise<void> {
tilman commented 2 years ago

@JannikZed ?

JannikZed commented 2 years ago

API handles max 25 salesorders at once, that's why we created this chunk size :) 25 is a hard limit.