search

trieschlab / MIMo

MIT License
30 stars 7 forks source link

Failed to initialise MimoStandUp environment #19

Closed dodio12138 closed 8 months ago

dodio12138 commented 8 months ago

I think this is because **kwargs are missing from MIMoStandupEnv.__init__() and MIMoStandupEnv.super.__init__() in the standup.py script ( Path: /mimoEnv/envs/standup.py ). After adding it, It can run.

Domattee commented 8 months ago

Thanks for pointing this out, fixed! Just out of curiosity, could you tell us the stack trace and what command lead to this issue? Both benchmarking and demo scripts run (for us anyway) even without the kwarg passthrough, it'd be interesting to see what argument and from what module/wrapper was causing problems.

dodio12138 commented 8 months ago

Of course, I use env = gym.make("MIMoStandup-v0", render_mode = 'human') to import the environment, and the Traceback displayed is: 

Traceback (most recent call last):
  File "/home/dodio/Desktop/BABY/myScene.py", line 11, in <module>
    env = gym.make("MIMoStandup-v0", render_mode = 'human')
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dodio/anaconda3/envs/BABY/lib/python3.11/site-packages/gymnasium/envs/registration.py", line 813, in make
    raise e
  File "/home/dodio/anaconda3/envs/BABY/lib/python3.11/site-packages/gymnasium/envs/registration.py", line 801, in make
    env = env_creator(**env_spec_kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: MIMoStandupEnv.__init__() got an unexpected keyword argument 'render_mode'

My running env: ubuntu 22.04.3 LTS python 3.11.5 mujoco 2.3.7 gymnasium 0.28.1

Domattee commented 8 months ago

Thanks! Turns out I really need to write a test suite, I would've thought illustrations.py or benchmark.py would use this parameter.