trietho / react-native-a-beep

A very lite module to play system sounds and beep for react-native apps (no sound files)
56 stars 34 forks source link

Error running pod install #4

Closed yankovalera closed 5 years ago

yankovalera commented 5 years ago

When I run pod install, I'm getting this:

[!] The RNReactNativeABeep pod failed to validate due to 1 error:

trietho commented 5 years ago

Hi @yankovalera I just merged a Pull Request that enable CocaPods Install, please help double check. Thanks to @MuhammadNayabButt for the pull request.

yankovalera commented 5 years ago

hi @trietho looks like if I try to install, I'm getting same version as before (with the error). New version has been released?

trietho commented 5 years ago

Oops, my bad! I forgot releasing it to npmjs. I just publish the latest code npmjs and I think you can try again. Thank you very much for your response, @yankovalera.

jeffmon commented 5 years ago

Hello @trietho,

I'm running the latest and pod install is running fine. I run into issues when trying to run RNBeep.beep();, I get this error:

IMG_3191

Any help would be appreciated, thank you!

yankovalera commented 5 years ago

Same here

trietho commented 5 years ago

@yankovalera @jeffmon I met the same issue. Please use the version 1.0.2 in the old fashion way while waiting for the fix. Thanks for let me know.

jeffmon commented 5 years ago

@trietho

I'm running version 1.0.2 and it runs fine in a simulator, but if I try to run it on my phone via Xcode, I get this error:

Screen Shot 2019-10-03 at 7 52 58 AM

Thanks for your help on this!

jeffmon commented 5 years ago

I was able to fix it by manually fixing /node_modules/react-native/React/RCTBridgeModule.h, replacing #import "RCTDefines.h" on line 10, with:

#if __has_include("RCTDefines.h")
#import "RCTDefines.h"
#else
#import <React/RCTDefines.h>
#endif

To continue this route I have to use https://github.com/ds300/patch-package for now to patch this.

trietho commented 5 years ago

@jeffmon @yankovalera Version 1.0.5 was released to npmjs. I tested. pod install will work as it is.

triethowvn commented 5 years ago

There is no comment in 20 days, so I think the problem was resolved at your side.