Closed squell closed 1 year ago
Number of dependencies and binary size impact report
Metric | main | PR #614 | Delta |
---|---|---|---|
Direct dependencies | 5 | 5 | - |
Total dependencies | 10 | 10 | - |
Binary size | 1.1 MiB | 1.1 MiB | - |
Text size | 652.5 KiB | 652.5 KiB | - |
Patch coverage has no change and project coverage change: +0.37
:tada:
Comparison is base (
7cf444e
) 85.86% compared to head (4c8e480
) 86.24%.:exclamation: Current head 4c8e480 differs from pull request most recent head 7f22ff5. Consider uploading reports for the commit 7f22ff5 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
A timestamp test was failing due to the different default setting for
use_pty
(which is enabled by default for sudo-rs, enabled by default in standard /etc/sudoers files, and is likely to become the default in sudo as well in the near future).This test has been split in two cases (
!use_pty
anduse_pty
) where we can see that sudo-rs and ogsudo behave the same.Closing #388
NOTE: The timeout-wait loop is perhaps not really necessary since both ogsudo and sudo-rs will prompt someone for input.