trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.
Other
2.9k stars 79 forks source link

Fix compliance test failing due to `use_pty` default behaviour. #614

Closed squell closed 1 year ago

squell commented 1 year ago

A timestamp test was failing due to the different default setting for use_pty (which is enabled by default for sudo-rs, enabled by default in standard /etc/sudoers files, and is likely to become the default in sudo as well in the near future).

This test has been split in two cases (!use_pty and use_pty) where we can see that sudo-rs and ogsudo behave the same.

Closing #388

NOTE: The timeout-wait loop is perhaps not really necessary since both ogsudo and sudo-rs will prompt someone for input.

github-actions[bot] commented 1 year ago

Number of dependencies and binary size impact report

Metric main PR #614 Delta
Direct dependencies 5 5 -
Total dependencies 10 10 -
Binary size 1.1 MiB 1.1 MiB -
Text size 652.5 KiB 652.5 KiB -
Dependencies diff ```diff └─ sudo-rs [v0.2.0-dev.20230703] ├─ glob [v0.3.1] ├─ libc [v0.2.147] ├─ log [v0.4.19] ├─ signal-hook [v0.3.15] | ├─ libc [v0.2.147] | ├─ signal-hook-registry [v1.4.1] | | └─ libc [v0.2.147] | └─ cc [v1.0.79] └─ signal-hook-registry [v1.4.1] ```
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.37 :tada:

Comparison is base (7cf444e) 85.86% compared to head (4c8e480) 86.24%.

:exclamation: Current head 4c8e480 differs from pull request most recent head 7f22ff5. Consider uploading reports for the commit 7f22ff5 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #614 +/- ## ========================================== + Coverage 85.86% 86.24% +0.37% ========================================== Files 62 62 Lines 8440 8440 ========================================== + Hits 7247 7279 +32 + Misses 1193 1161 -32 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/memorysafety/sudo-rs/pull/614/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=memorysafety)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.