Closed pvdrz closed 1 year ago
Patch coverage: 86.95
% and project coverage change: +0.46
:tada:
Comparison is base (
bb0d6bc
) 86.34% compared to head (5f87e79
) 86.80%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Number of dependencies and binary size impact report
Metric | main | PR #621 | Delta |
---|---|---|---|
Direct dependencies | 5 | 5 | - |
Total dependencies | 10 | 10 | - |
Binary size | 1.1 MiB | 1 MiB | -0.5% |
Text size | 630.5 KiB | 630.2 KiB | - |
Describe the changes done on this pull request This PR introduces a new
FileCloser
type with aFileCloser::close_the_universe
method able to close every file that's notstdin/out/err
or explicitly preserved usingFileCloser::except
.close_the_universe
is called just beforeCommand::exec
is run. The only files preserved usingexcept
are the pipe used for error reporting ifCommand::exec
fails and thedup
ed versions of the follower side of the pty.The
exec::no_pty
module was refactored to usefork
+Command::exec
instead ofCommand::spawn
to be able to callclose_the_universe
without interfering withCommand::spawn
's inner workings.Additionally the calls to
exit
were replaced by_exit
in an attempt to fix the spurious errors about*.profraw
files being corrupt.Pull Request Checklist