Closed pvdrz closed 1 year ago
Number of dependencies and binary size impact report
Metric | main | PR #643 | Delta |
---|---|---|---|
Direct dependencies | 3 | 3 | - |
Total dependencies | 4 | 4 | - |
Binary size | 978.5 KiB | 978.6 KiB | - |
Text size | 570.7 KiB | 571.1 KiB | - |
Patch coverage: 51.16
% and project coverage change: -10.77
:warning:
Comparison is base (
729d1b0
) 86.32% compared to head (31b90d5
) 75.56%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Describe the changes done on this pull request This PR replaces all the individual calls to
exit
for child processes for a single call at the top of theexec
module. This will guarantee that any internal value created by theexec
module will be properly dropped.It would be possible to move this call to
exit
upper so other parts of sudo can properly drop any values that should be dropped according to their internal logic.It also replaces the calls to
exit
for_exit
for three reasons:at_exit
callback is not run.cc @japaric
Pull Request Checklist