Closed pvdrz closed 1 year ago
Number of dependencies and binary size impact report
Metric | main | PR #649 | Delta |
---|---|---|---|
Direct dependencies | 3 | 3 | - |
Total dependencies | 4 | 4 | - |
Binary size | 978.4 KiB | 983.6 KiB | +0.5% |
Text size | 570.1 KiB | 572.6 KiB | +0.4% |
Patch coverage has no change and project coverage change: -0.36
:warning:
Comparison is base (
4f7c03f
) 59.50% compared to head (af8af21
) 59.15%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I couldn't find a way to write a compliance test for this as stty doesn't send SIGWINCH when used to update the terminal size.
you can send SIGWINCH to a process using kill
. even if you can't actually resize the terminal, you can at least test that the ioctl calls don't fail and that the signal gets forwarded to the child
I couldn't find a way to write a compliance test for this as stty doesn't send SIGWINCH when used to update the terminal size.
you can send SIGWINCH to a process using
kill
. even if you can't actually resize the terminal, you can at least test that the ioctl calls don't fail and that the signal gets forwarded to the child
Apparently the shell notices this change
I couldn't find a way to write a compliance test for this as stty doesn't send SIGWINCH when used to update the terminal size.
you can send SIGWINCH to a process using
kill
. even if you can't actually resize the terminal, you can at least test that the ioctl calls don't fail and that the signal gets forwarded to the child
Apparently the shell sends SIGWINCH
to the foreground process group if you change the size with stty
. So if you open a terminal and run
# to get the terminal path
tty
sh -c "trap \"echo GOT SIGWINCH\" WINCH; sleep 20"
and then, from another terminal you run
stty -F/dev/pts/N cols 42
You'll see the GOT SIGWINCH
message in the first terminal after 20 secs
Describe the changes done on this pull request This PR updates the
use_pty
behavior so it can handleSIGWINCH
correctly.I couldn't find a way to write a compliance test for this as
stty
doesn't sendSIGWINCH
when used to update the terminal size.Pull Request Checklist