trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.
Other
2.9k stars 79 forks source link

test that su respects /etc/resource/limits #652

Closed japaric closed 1 year ago

japaric commented 1 year ago

util-linux su appears to do the same as ogsudo so adding this test as a compliance test. util-linux su does not set core dump file size to 0 like ogsudo does so I'm leaving that test out. if we want to implement that core dump file size behavior in su-rs, the tests for that should go in the e2e-tests package.

closes #629

github-actions[bot] commented 1 year ago

Number of dependencies and binary size impact report

Metric main PR #652 Delta
Direct dependencies 3 3 -
Total dependencies 4 4 -
Binary size 992.2 KiB 992.3 KiB -
Text size 577.1 KiB 577.1 KiB -
Dependencies diff ```diff └─ sudo-rs [v0.2.0-dev.20230703] ├─ glob [v0.3.1] ├─ libc [v0.2.147] └─ log [v0.4.19] ```
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (bc56b1b) 58.46% compared to head (17a9bcd) 58.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #652 +/- ## ======================================= Coverage 58.46% 58.46% ======================================= Files 66 66 Lines 8850 8850 ======================================= Hits 5174 5174 Misses 3676 3676 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.