Closed dlorenc closed 1 year ago
Thanks! Can you run a
cargo fmt
over your changes? (see the CI output).
That was fast, thanks!
Looks like a flake or unrelated to the PR...
Looks like a flake or unrelated to the PR...
Totally; code coverage collection has been failing us since yesterday. Probably going to remove that from the CI.
Patch coverage: 100.00
% and project coverage change: -6.15
:warning:
Comparison is base (
824a4ad
) 86.35% compared to head (25d8be3
) 80.21%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for deflaking!
When I built on arm (aarch64), I got this compiler error:
After some research, I learned that this is an architecture issue - on many platforms char is mapped to i8, but not on aarch64. Here's a source: https://github.com/fede1024/rust-rdkafka/issues/121
With this change it now builds successfully on arm!