Closed xy2i closed 1 year ago
Patch coverage: 40.65%
and project coverage change: -0.05%
:warning:
Comparison is base (
81fe097
) 54.67% compared to head (f37c8f2
) 54.62%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for your contribution! 🎉 Someone will review it next week.
Related: #740; if we decide to merge that this one should probably close.
Closing in favor of #740
We don't want to compute the hostname each time, as it may change between invocations.
This needs a small refactor: the hostname is computed in
Context
, but by this time the sudoers file is already parsed and analyzed:But things like the hostname and the current user don't depend on sudoers and command line opts. Split these out into another context,
SystemContext
, and pass them when analyzing the sudoers file.Fixes https://github.com/memorysafety/sudo-rs/issues/676