search

trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.
Other
2.9k stars 79 forks source link

use `std::os::unix::fs::fchown` #755

Open japaric opened 1 year ago

japaric commented 1 year ago

instead of the unsafe libc::fchown. this API will be stabilized in Rust 1.73 (~ 2023-10-05)

https://github.com/memorysafety/sudo-rs/blob/9b9a7e428240930d213723ca39be16752c7d5e02/src/system/file/chown.rs#L16

rnijveld commented 1 year ago

I would suggest we only do this once our MSRV increases past this version some time in the future, and not increase our MSRV just because of this feature.

squell commented 1 year ago

Maybe we can introduce some labels for issues that have to wait only because of a MSRV-related issue?

pvdrz commented 1 year ago

@squell maybe we could do milestones for these so we can actually track the specific version for each issue, what do you think?