search

trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.
Other
2.88k stars 77 forks source link

update `self_check` function to work with sudo invoked through setuid wrapper #772

Closed japaric closed 12 months ago

japaric commented 12 months ago

thanks @R-VdP for the initial implementation. co-authored by @rnijveld

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01% :warning:

Comparison is base (e2edeca) 55.24% compared to head (691022b) 55.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #772 +/- ## ========================================== - Coverage 55.24% 55.23% -0.01% ========================================== Files 72 72 Lines 9842 9841 -1 ========================================== - Hits 5437 5436 -1 Misses 4405 4405 ``` | [Files Changed](https://app.codecov.io/gh/memorysafety/sudo-rs/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=memorysafety) | Coverage Δ | | |---|---|---| | [src/common/error.rs](https://app.codecov.io/gh/memorysafety/sudo-rs/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=memorysafety#diff-c3JjL2NvbW1vbi9lcnJvci5ycw==) | `9.80% <0.00%> (ø)` | | | [src/sudo/mod.rs](https://app.codecov.io/gh/memorysafety/sudo-rs/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=memorysafety#diff-c3JjL3N1ZG8vbW9kLnJz) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/memorysafety/sudo-rs/pull/772/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=memorysafety)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

squell commented 12 months ago

Hat tip to @yorickvP for noticing, as well.

github-actions[bot] commented 12 months ago

Number of dependencies and binary size impact report

Metric main PR #772 Delta
Direct dependencies 3 3 -
Total dependencies 4 4 -
Binary size 1021.7 KiB 1021.5 KiB -
Text size 593.5 KiB 593.2 KiB -
Dependencies diff ```diff └─ sudo-rs [v0.2.0] ├─ glob [v0.3.1] ├─ libc [v0.2.147] └─ log [v0.4.20] ```
r-vdp commented 12 months ago

Cool, I didn't get the time to make a PR for this patch yet, but glad to see it merged!