trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.
Other
2.88k stars 77 forks source link

add sentence about globbing not being supported #775

Closed squell closed 12 months ago

squell commented 12 months ago

Feel free to change the precise wording, but this feels like it is a noteworthy deviation from ogsudo to mention.

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage has no change and project coverage change: +0.08% :tada:

Comparison is base (4c177bc) 55.24% compared to head (df877ef) 55.33%. Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #775 +/- ## ========================================== + Coverage 55.24% 55.33% +0.08% ========================================== Files 72 72 Lines 9841 9837 -4 ========================================== + Hits 5437 5443 +6 + Misses 4404 4394 -10 ``` [see 8 files with indirect coverage changes](https://app.codecov.io/gh/memorysafety/sudo-rs/pull/775/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=memorysafety)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 12 months ago

Number of dependencies and binary size impact report

Metric main PR #775 Delta
Direct dependencies 3 3 -
Total dependencies 4 4 -
Binary size 1021.5 KiB 1021.5 KiB -
Text size 593.2 KiB 593.2 KiB -
Dependencies diff ```diff └─ sudo-rs [v0.2.0] ├─ glob [v0.3.1] ├─ libc [v0.2.147] └─ log [v0.4.20] ```
rnijveld commented 12 months ago

I do think that we should, separately from this PR, see if we can improve our diagnostics surrounding this

squell commented 12 months ago

I do think that we should, separately from this PR, see if we can improve our diagnostics surrounding this

Improving simply means * becomes a parse error in arguments inside a CommandSpec. Anything else would be confusing and needlessly complex. We should not discuss this any further -- it takes about 5 minutes to implement :-)