search

trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.
Other
2.88k stars 77 forks source link

replace `unsafe` CStr construction with a macro that compile time checks CStr invariants #779

Closed japaric closed 12 months ago

japaric commented 12 months ago

co-authored by @rnijveld

extracted this out of a WIP branch that addresses #748

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage has no change and project coverage change: +0.03% :tada:

Comparison is base (6748b1c) 55.33% compared to head (4e3166f) 55.36%. Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #779 +/- ## ========================================== + Coverage 55.33% 55.36% +0.03% ========================================== Files 72 72 Lines 9837 9833 -4 ========================================== + Hits 5443 5444 +1 + Misses 4394 4389 -5 ``` | [Files Changed](https://app.codecov.io/gh/memorysafety/sudo-rs/pull/779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=memorysafety) | Coverage Δ | | |---|---|---| | [src/visudo/mod.rs](https://app.codecov.io/gh/memorysafety/sudo-rs/pull/779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=memorysafety#diff-c3JjL3Zpc3Vkby9tb2QucnM=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/memorysafety/sudo-rs/pull/779/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=memorysafety)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

japaric commented 12 months ago

shelving this for now because it's blocked by a MSRV bump