search

trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.
Other
2.87k stars 76 forks source link

improve pty error #807

Closed squell closed 7 months ago

squell commented 9 months ago

This make it clear that the error that occurs when a PTY cannot be opened pertains to the PTY, and not to the command itself, i.e. it will produce:

sudo-rs: cannot execute '/usr/bin/ls': unable to open pty
codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (328be1e) 57.46% compared to head (e544180) 57.36%. Report is 11 commits behind head on main.

Files Patch % Lines
src/exec/use_pty/parent.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #807 +/- ## ========================================== - Coverage 57.46% 57.36% -0.11% ========================================== Files 74 74 Lines 10523 10559 +36 ========================================== + Hits 6047 6057 +10 - Misses 4476 4502 +26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

squell commented 9 months ago

Note: needs some work to figure out why the compliance test is failing.

Edit Passes the compliance tests locally. :thinking:

Edit Seems just a GitHub issue. Very strange.