search

trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.
Other
2.87k stars 76 forks source link

To add a `SAFETY` comment to the now function #811

Closed ZhangHanDong closed 7 months ago

ZhangHanDong commented 8 months ago

The unsafe block should include necessary comments to complete the safety abstraction.

In the implementation of the now function, necessary SAFETY comments should be added to explain its safety, with particular emphasis on the fact that libc::clock_gettime initializes the spec.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7f82d3a) 57.32% compared to head (ec6d41a) 57.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #811 +/- ## ========================================== - Coverage 57.32% 57.31% -0.01% ========================================== Files 74 74 Lines 10505 10505 ========================================== - Hits 6022 6021 -1 - Misses 4483 4484 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

squell commented 8 months ago

Thanks for the contribution! A review will be upcoming :)

squell commented 7 months ago

Note: there are some CI issues due to an update for clippy; fixing those, I expect this to be mergeable then.