search

trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.
Other
2.87k stars 76 forks source link

Fixed issues#769 : Add newtypes for UserId, GroupId and ProcessId #812

Open ZhangHanDong opened 8 months ago

ZhangHanDong commented 8 months ago

fixed #769

codecov[bot] commented 8 months ago

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (7f82d3a) 57.32% compared to head (eb5f488) 57.73%.

Files Patch % Lines
src/system/mod.rs 80.00% 8 Missing :warning:
src/exec/mod.rs 0.00% 5 Missing :warning:
src/exec/use_pty/backchannel.rs 0.00% 3 Missing :warning:
src/exec/use_pty/monitor.rs 0.00% 3 Missing :warning:
src/system/timestamp.rs 85.71% 3 Missing :warning:
src/common/error.rs 0.00% 2 Missing :warning:
src/exec/interface.rs 0.00% 1 Missing :warning:
src/exec/no_pty.rs 0.00% 1 Missing :warning:
src/exec/use_pty/parent.rs 0.00% 1 Missing :warning:
src/su/context.rs 50.00% 1 Missing :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #812 +/- ## ========================================== + Coverage 57.32% 57.73% +0.40% ========================================== Files 74 74 Lines 10505 10649 +144 ========================================== + Hits 6022 6148 +126 - Misses 4483 4501 +18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

squell commented 7 months ago

Can you rebase this on the current main? And also, would you like some assistance with the compliance test failure?