search

trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.
Other
2.87k stars 76 forks source link

Add path information to parse errors originating from included files. #815

Closed squell closed 7 months ago

squell commented 7 months ago

Closing #806

codecov[bot] commented 7 months ago

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (2fa9234) 57.36% compared to head (a392c00) 57.27%. Report is 2 commits behind head on main.

Files Patch % Lines
src/sudoers/mod.rs 39.47% 23 Missing :warning:
src/sudo/mod.rs 0.00% 6 Missing :warning:
src/visudo/mod.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #815 +/- ## ========================================== - Coverage 57.36% 57.27% -0.10% ========================================== Files 74 74 Lines 10559 10583 +24 ========================================== + Hits 6057 6061 +4 - Misses 4502 4522 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

squell commented 7 months ago

Note: there are still a few places where we don't provide "location information" (i.e. semantic errors, that pop up during semantic analysis). Providing those would require adding positional information to the AST in a few place. We could do that, but that should be a separate issue.

rnijveld commented 7 months ago

I've added an issue (#827) to add the tests later