trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.
Other
2.87k stars 76 forks source link

Add Arch Linux #838

Closed taotieren closed 3 months ago

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.97%. Comparing base (4f93acb) to head (df3f5f8). Report is 10 commits behind head on main.

:exclamation: Current head df3f5f8 differs from pull request most recent head 6836c37. Consider uploading reports for the commit 6836c37 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #838 +/- ## ========================================== - Coverage 57.98% 57.97% -0.01% ========================================== Files 75 75 Lines 10560 10560 ========================================== - Hits 6123 6122 -1 - Misses 4437 4438 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rnijveld commented 5 months ago

I'm not in the Arch ecosystem myself, is yay enough of a default that we can assume Arch Linux users will always use it and know how to install it?

taotieren commented 5 months ago

I'm not in the Arch ecosystem myself, is yay enough of a default that we can assume Arch Linux users will always use it and know how to install it?我自己不在 Arch 生态系统中,我们是否可以假设 Arch Linux 用户会一直使用它并知道如何安装它?

The packet address of the AUR for sudo-rs is: https://aur.archlinux.org/packages/sudo-rs arch users can install via AUR, generally speaking, arch users will understand where to install from when they see this command line, if it is not clear, add an AUR connection address.

pvdrz commented 5 months ago

I'm not in the Arch ecosystem myself, is yay enough of a default that we can assume Arch Linux users will always use it and know how to install it?

No, it isn't.

However, the important point here is that sudo-rs is available in the arch user repos (AUR), which is how community packages that aren't part of the official repos are installed. Just like how Fedora has Copr and OpenSuse has OBS. The only difference is that there's no default tool to interact with the AUR

I think a clearer way to put this would be to say that there's a sudo-rs package in the AUR, add a link to https://aur.archlinux.org/packages/sudo-rs and probably a link to https://wiki.archlinux.org/title/AUR_helpers as well.

taotieren commented 5 months ago

@pvdrz Thanks for the advice. I'll submit the new changes.

pvdrz commented 3 months ago

@taotieren could you rebase this PR so CI passes and we can merge it? Thanks :clap:

squell commented 3 months ago

@taotieren I can lend a hand in fixing the CI updates; maybe it's good if we separate the "fix the CI" (which is not your fault that it is complaining) from the "add Arch Linux" stuff.

squell commented 3 months ago

CC PR https://github.com/memorysafety/sudo-rs/pull/844. If that's merged, rebasing this on main should do the trick. I've included your CI-related commit there.

taotieren commented 3 months ago

@taotieren I can lend a hand in fixing the CI updates; maybe it's good if we separate the "fix the CI" (which is not your fault that it is complaining) from the "add Arch Linux" stuff.

Thanks!