`/proc/stat` hierarchy is not being parsed correctly anymore (regression)

trifectatechfoundation / sudo-rs

A memory safe implementation of sudo and su.

Other

2.9k stars 80 forks source link

`/proc/stat` hierarchy is not being parsed correctly anymore (regression) #889

Open squell opened 3 hours ago

squell commented 3 hours ago

After the merger of #887 (which passed the CI while being 'up to date' with main, which is now the rule since the merge queue was disabled), CI on main seems to be consistently failing.

Two possibilities:

This can be related to whatever #887 touched (timestamping seems implicated), and we may have observed a "flaky success"?
~~We have made the CI more flaky by removing all the caching.~~

squell commented 3 hours ago

So it's not consistently the same test that fail, but I do see a pattern that they are time-stamp related (although sometimes a signal test fails as well). That might be due to poor performance of the CI.

squell commented 2 hours ago

Found the culprit: PR #887 completely broke the delicate /proc/stat parser we had.