search

trifectatechfoundation / teach-rs

A modular, reusable university course for Rust
https://teach-rs.trifectatech.org
Creative Commons Attribution Share Alike 4.0 International
2.92k stars 137 forks source link

Removing as_slice in A3 #84

Closed SamClercky closed 9 months ago

SamClercky commented 10 months ago

Hi,

In the exercises for A3 .as_slice() is used in LocalStorageVec::from (last test case).

It is however nowhere mentioned to implement From<&[T; N]> for LocalStorageVec.

Implementations at the end of the exercises in A3:

This PR removes the use of as_slice, so the last section can be more easily finished.

Kind regards,

SamClercky

cc @rubdos

hdoordt commented 9 months ago

Hi @SamClercky , thanks for this! I'm currently in the process of heavily refactoring the repo content. When that's done, I'll be happy to pull in your changes. Turns out it's better to pull in your content first instead

rubdos commented 9 months ago

heavily refactoring the repo content

Cool! Looking forward to it :-)