search

trifectatechfoundation / teach-rs

A modular, reusable university course for Rust
https://teach-rs.trifectatech.org
Creative Commons Attribution Share Alike 4.0 International
2.98k stars 140 forks source link

Add discriminant to the enumeration #85

Closed alexandruradovici closed 1 year ago

alexandruradovici commented 1 year ago

The pull request improves the description of the enumeration.

  1. It states that each enumeration variant had a discriminant and fixes the text that says that the enumeration's size is the equivalent of its largest variant;
  2. Modifies the images to reflect this;
  3. Reuses the original draw.io image, as the new SVGs look odd.
alexandruradovici commented 1 year ago

Hi, any feedback for this?

hdoordt commented 1 year ago

Hi @alexandruradovici, thanks for this! I'm currently in the process of heavily refactoring the repo content. When that's done, I'll be happy to pull in your changes.

alexandruradovici commented 1 year ago

Do you have any time frame for this? I would like to use the class at Politehnica University of Bucharest and it starts in two weeks. Would love to see the new material.

hdoordt commented 1 year ago

@alexandruradovici I'm afraid my refactor will take a while longer. However, I'd love to facilitate you however I can and will merge your PRs after review and add your changes to my branch instead