Stack heap diagram fixes

trifectatechfoundation / teach-rs

A modular, reusable university course for Rust

https://teach-rs.trifectatech.org

Creative Commons Attribution Share Alike 4.0 International

2.92k stars 137 forks source link

Stack heap diagram fixes #89

Closed andybalaam closed 9 months ago

andybalaam commented 10 months ago

After:

Before:

Included here are these changes. Let me know if you'd like me to split them out into separate PRs:

Set the font colour so that 'Frame 1' etc. are visible in dark mode
Expand the 'Allocated' box to fit the text
Increase the height of the diagram when more memory is used
Replace the arrow for the stack pointer - the arrow that was used before was not visible on my machine (Ubuntu 22.04)
Move the stack pointer arrow closer to the diagram

hdoordt commented 9 months ago

~~Hi @andybalaam, thanks for this! I'm currently in the process of heavily refactoring the repo content. When that's done, I'll be happy to pull in your changes.~~ Turns out it's best to do this the other way around