search

trifectatechfoundation / zlib-rs

A safer zlib
zlib License
139 stars 15 forks source link

just always initialize the window buffer with zeros #234

Closed folkertdev closed 4 weeks ago

folkertdev commented 1 month ago

fix #232

turns out this does not really affect performance (at least, not on modern systems), so we may was well just rule out this whole class of issues instead of trying to patch the problems we find. Also cleans up the code a bunch.

cc @inahga

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 98.06763% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
test-libz-rs-sys/src/inflate.rs 97.24% 3 Missing :warning:
zlib-rs/src/inflate/window.rs 96.00% 1 Missing :warning:
Files with missing lines Coverage Δ
zlib-rs/src/adler32.rs 98.97% <100.00%> (-0.05%) :arrow_down:
zlib-rs/src/adler32/avx2.rs 94.31% <ø> (ø)
zlib-rs/src/allocate.rs 98.95% <100.00%> (+1.14%) :arrow_up:
zlib-rs/src/crc32.rs 95.91% <100.00%> (-0.11%) :arrow_down:
zlib-rs/src/crc32/pclmulqdq.rs 96.65% <100.00%> (-0.05%) :arrow_down:
zlib-rs/src/inflate/writer.rs 87.66% <100.00%> (+0.16%) :arrow_up:
zlib-rs/src/inflate/window.rs 97.47% <96.00%> (-0.50%) :arrow_down:
test-libz-rs-sys/src/inflate.rs 97.44% <97.24%> (-0.02%) :arrow_down:

... and 3 files with indirect coverage changes