search

triffid / FiveD_on_Arduino

Rewrite of reprap mendel firmware
http://forums.reprap.org/read.php?147,33082
GNU General Public License v2.0
30 stars 12 forks source link

Resend Request changed from "Resend:" to "rs " #9

Closed dpslwk closed 13 years ago

dpslwk commented 13 years ago

As of reprap-mendel-20100806, the RepRap java host expects resend requests using the new "rs " format only, the version before this only excepted "Resend:"

Repsnapper as of SVN 348 accepts both formats.

Traumflug commented 13 years ago

First of all, thanks for reporting this.

This almost willfully breaking of compatibility by RepRap Host is ridiculous. I've requested an explanation on the reprap-dev mailing list.

Now, commiting the patch breaks compatibility with older RepRap Hosts any likely many other GCode sending apps. Looks like we'd have to introduce something like

// #define REPRAP_HOST_COMPATIBILITY 2010-01-01
#define REPRAP_HOST_COMPATIBILITY 2010-08-06
// #define REPRAP_HOST_COMPATIBILITY <date of next RepRap Host compatibility break>

#if defined REPRAP_HOST_COMPATIBILITY && REPRAP_HOST_COMPATIBILITY < 2010-08-06
serial_writestr_P(PSTR("Resend:"));
#else
serial_writestr_P(PSTR("rs "));
#endif

For now, let's see what the mailing list people tell us :-)

Traumflug commented 13 years ago

OK, the go-home message from the mailing list is, breaking backwards compatibility is intentional. See: http://github.com/triffid/FiveD_on_Arduino/commit/a565f31dbb36d0be615770c1a16db32cd77bfcd6