Closed ghost closed 5 years ago
There is no need to make a release for this. Just push it with next release
2 Warnings | |
---|---|
:warning: | Big PR |
:warning: | There are changes to sources files, but not the test files? |
Generated by :no_entry_sign: Danger
This is a breaking change (removes public functionality), so it shouldn't be merged before we bump to version 1.2.0.
Sure! Nice one with milestone.
I think we should use that for future releases
But this is not urgent! So lets wait with merge until 1.2.0 🚀
id
properties should beinternal
.
They are default internal or should we mark them explicit internal so others now they are only internal use?
id
properties should beinternal
.They are default internal or should we mark them explicit internal so others now they are only internal use?
You marked them as public
, so just delete that part 😉
We have default implementations. Reusable.swift doesn't make sense.