search

trifork / TriforkSwiftExtensions

Generic Trifork Swift Extensions
MIT License
8 stars 6 forks source link

Remove reusable #45

Closed ghost closed 5 years ago

ghost commented 5 years ago

We have default implementations. Reusable.swift doesn't make sense.

ghost commented 5 years ago

There is no need to make a release for this. Just push it with next release

trifork-bot commented 5 years ago
2 Warnings
:warning: Big PR
:warning: There are changes to sources files, but not the test files?

Generated by :no_entry_sign: Danger

ghost commented 5 years ago

This is a breaking change (removes public functionality), so it shouldn't be merged before we bump to version 1.2.0.

ghost commented 5 years ago

Sure! Nice one with milestone.

I think we should use that for future releases

ghost commented 5 years ago

But this is not urgent! So lets wait with merge until 1.2.0 🚀

ghost commented 5 years ago

id properties should be internal.

They are default internal or should we mark them explicit internal so others now they are only internal use?

ghost commented 5 years ago

id properties should be internal.

They are default internal or should we mark them explicit internal so others now they are only internal use?

You marked them as public, so just delete that part 😉