trifork / erjang

A JVM-based Erlang VM
http://www.erjang.org
Apache License 2.0
727 stars 62 forks source link

One place for external dependencies. #14

Closed eriksoe closed 13 years ago

eriksoe commented 14 years ago

As it is now, paths to OTP, erl and erlc are hard-coded in the files src/test/java/erjang/AllTests.java, src/test/java/erjang/TestRunFile.java. I suggest creating a directory ext/ for holding symlinks to these external entities; or, if that won't work for Windows users, that the paths in question are put into appropriate Java properties and set in build.xml.

krestenkrab commented 14 years ago

Yes, that's ugly; and something we need to fix soon.

andytill commented 14 years ago

I had to change this also to build the OTP, would path be better as an environment variable than a property?

eriksoe commented 13 years ago

I believe this issue to be fixed now, with erjang_cfg.properties containing all such configuration.

krestenkrab commented 13 years ago

Maybe we should consider having this file in "erjang_cfg.properties.template" so it doesn't get pushed to the repo (have happened several times)...