trigg / Discover

Yet another discord overlay for linux
GNU General Public License v3.0
651 stars 28 forks source link

Feature request: Speaker Grace Period #294

Closed Hubro closed 1 year ago

Hubro commented 1 year ago

First of all, great job removing the only remaining thing I missed from gaming on Windows :smile: :heart:

Discover is freaking amazing, but I have one use case where it could be better.

I often sit in Discord rooms with 25-50 people (raiding in World of Warcraft) which means I absolutely need to have Show Speakers Only enabled. However, people pop up as they speak, then they immediately disappear, often before I have time to see who it was.

What would be amazing is to add a supplementary option called Speaker Grace Period. This field would allow extra time in seconds where speakers would be visible before they disappear. This could be set to something like 3 seconds to give the user time to read the names of speakers before they disappear, or it could be set to something like 10-30 seconds to give a persistent view of active speakers. (In a raid group, the majority of participants are often only there to hear raid calls.)


(After that, the only thing remaining is to make a Vulkan implementation so the overlay can be used in exclusive full screen games :grin:)

trigg commented 1 year ago

This is a very good idea, and this explains quite well this use case.

A temporary and not-great measure would be to sort by last spoken and reduce the size of the window down to a manageable size, forcing most of the list to be cut off. Obviously this is not ideal in any way.

the only thing remaining is to make a Vulkan implementation

I know what I have to do but I don't know if I have the strength to do it.

trigg commented 1 year ago

Thank you for the report & pull request! I've added a 1 FPS timer to voice chat to redraw. Shouldn't make any notable difference to performance but does ensure people drop off the list correctly

Hubro commented 1 year ago

Installed discover-overlay-git v0.6.3.r12.gaf5c569-1 from AUR now and tested it a bit, works freaking flawlessly :grin: :rocket:

trigg commented 1 year ago

Glad to hear! I have to give you credit for the feature.