trigg / Discover

Yet another discord overlay for linux
GNU General Public License v3.0
651 stars 28 forks source link

Feature Request: automatically set positioning to floating on cinnamon #322

Closed binarynoise closed 8 months ago

binarynoise commented 8 months ago

To prevent #299 and #98 in future, would it be possible to detect if the Discover Overlay is run on cinnamon to automatically switch to floating?

trigg commented 8 months ago

This might be a potential fix. It would need a sensible way to find out if the user is on cinnamon...

Could you please provide the output of env | grep XDG_SESSION_DESKTOP I'm hoping that will be enough to work off of

binarynoise commented 8 months ago
$ env | grep XDG_SESSION_DESKTOP
XDG_SESSION_DESKTOP=cinnamon
trigg commented 8 months ago

Ah I hoped so!

Yep I'll look into this then

trigg commented 8 months ago

It's not the prettiest, but it will ignore 'edge' choice in cinnamon desktop now.

To really call this fixed we probably need a way to explain this to new users

binarynoise commented 8 months ago

Next step could be disabling the anchored radio box in the settings UI. I don't program in python, otherwise I'd help you with that... Thanks for the workaround though.

trigg commented 8 months ago

That's done too. I'll close for now as this shouldn't cause further issue.