search

trigger-corp / browser-extensions

Build and run cross-platform browser extensions from one codebase.
Other
312 stars 52 forks source link

`.forgeignore` not working as expected #16

Closed patcon closed 10 years ago

patcon commented 10 years ago

I tried adding ./bower_components/ to this forgeignore file: https://github.com/gittip/Gittip-Everywhere/blob/trigger-corp-browser-extensions/src/.forgeignore

(Hoping to ignore the src/bower_components directory.)

When I run forge-extension build chrome from the repo root, it still copies that directory and I see it in development/chrome/src.

Is this the expected behaviour?

patcon commented 10 years ago

Tried all of these separately, btw:

./bower_components
./bower_components/
./bower_components/*
./bower_components/**
makern commented 10 years ago

I noticed the same thing for files which are in forgeignore by default. As far as I can tell from looking through the code and adding some logging forgeignore is actually never used. It appears the build system was changed a bit when the code was open sourced and some things don't work anymore as described in the old documentation.

Support for forgeignore should be easy to add back though. I might look into this if none of the original developers has any comments on the issue.