search

trigger-corp / browser-extensions

Build and run cross-platform browser extensions from one codebase.
Other
312 stars 52 forks source link

Remove Apture feedback dialog (IE) #33

Closed makern closed 10 years ago

makern commented 10 years ago

This removes the feedback dialog which is shown when unregistering the BHO and the extension name contains "Apture". The dialog seems to have little generic use in its current form and submits feedback to a hardcoded trigger.io url.

Assuming "Apture" refers to http://www.apture.com/ the orginal use case for this code is long gone and I vote for removing it in the interest of making the codebase easier to maintain.

Apologies for BHO.rc being treated as binary but there seems to be no good way get git to do sane diffs on the UTF-16 format the Microsoft resource compiler requires.

makern commented 10 years ago

@antoinevg Would you mind merging this or let me know if you want to reject it? Because of the binary .rc files I can't send independent pull requests for some other things I have queued up.

Once this has been merged I can rebase and send the other pull requests without causing conflicts.

makern commented 10 years ago

Cheers! :)