search

triggerdotdev / trigger.dev

Trigger.dev is the open source background jobs platform.
https://trigger.dev/changelog
Apache License 2.0
8.55k stars 518 forks source link

Feat: do we fancy a native Astro integration? #345

Closed lirantal closed 11 months ago

lirantal commented 1 year ago

Hey folks!

Similar to the Express and Next.js packages, do we want to have a native Astro integration package as part of the officially provided packages from Trigger.dev?

See the following resources for more context:

Of course, that would be amazing! Here's everything I can think of at the moment that would be nice to do to get astro support in (this isn't to say you should do these, just that they should be done at some point):

### Tasks
- [x] #354 Add astro adapter package to packages in the monorepo as @trigger.dev/astro
- [ ] https://github.com/triggerdotdev/examples/pull/5 Add example Astro project to the examples repo: https://github.com/triggerdotdev/examples
- [x] Add a Quick start guide to the Trigger.dev/docs
- [x] Add support for astro in @trigger.dev/cli init
ericallam commented 1 year ago

Of course, that would be amazing! Here's everything I can think of at the moment that would be nice to do to get astro support in (this isn't to say you should do these, just that they should be done at some point):

lirantal commented 1 year ago

Sounds like a good list. I might just tackle them as one-by-one PRs to make it scoped and easier to review and iterate while working to land these in officially.

lirantal commented 1 year ago

@ericallam I think you can remove the bullet-list you created as I copied it over to my opening comment body as a tasklist so it is easier to track.

On that note, see first PR introduced for the astro package.

ericallam commented 1 year ago

@lirantal I detailed in a github discussion here all the steps it would take to "officially" support another framework for Trigger.dev, thought you might find it interesting for the Astro work.

lirantal commented 11 months ago

Looks like this is now already shipped thanks to:

So I'd imagine we can close?

matt-aitken commented 11 months ago

@lirantal yep this is done, thanks a lot 🤩