triggerdotdev / trigger.dev

Trigger.dev is the open source background jobs platform.
https://trigger.dev/changelog
Apache License 2.0
8.55k stars 518 forks source link

Dashboard Freezes When Clicking on Task with Large Output #346

Open nickscamara opened 1 year ago

nickscamara commented 1 year ago

Hi there,

I've noticed a small bug when clicking on a task that has a big output inside a run. It seems like the cloud dashboard freezes.

Ps. Been loving the trigger platform btw! Great work!

ericallam commented 1 year ago

@nickscamara thanks for the report! Could you send me the Run ID so I can take a look at the size of the task output? If you are able to get the Run page to load:

CleanShot 2023-08-16 at 22 41 14@2x

matt-aitken commented 1 year ago

I've experienced this too @nickscamara. With one of our jobs we used to manage our beta list.

@ericallam you'll be able to access this run and if you click the "Get all responses" task you'll experience it: https://test-cloud.trigger.dev/orgs/triggerdev-8694/projects/admin-area-4W1-/jobs/beta-list-manual-sync/runs/clk6v2vvz023pn03sllk2w84x/tasks/01h5hy9snjmc6q8jaqnb1aa0f8

There are two things going on here I think:

  1. We should have a loading state on the right-hand Outlet so it's clear it's loading.
  2. The JSON is massive so the code view is probably spending a long time generating generating all the HTML elements for display.

That JSON is 492KB, 14,490 lines.

nickscamara commented 1 year ago

@ericallam Here is a run id where it happens: clle9al4h2p0ilr38dxyxdwmr

Thanks!