activate VPN sendgrid.js in terminal if not already connected

crispyabsurdist commented 8 months ago

PR Summary

Expansion of functionalities in sendgrid.js Several new import statements have been added for exec, fetch, and readline commands. These are commands that allow the program to perform specific actions and fetch data from various sources.
Introduction of new functions Three new functions have been introduced: connectToVPN, proceedWithSendGrid and checkIfUserIsInOffice. These functions add new capabilities like ensuring secure network connectivity, proceeding with SendGrid operations, and checking the user's location status before proceeding, respectively.
Revision in createSendGrid function The createSendGrid function has been modified to use the new checkIfUserIsInOffice function, which determines if the user is within the office environment.
Enhancements in error handling and user notifications The error message in createSendGrid function and the writeInfo statement have been modified to provide clearer and more specific information to the user. This helps simplify troubleshooting when there's a hiccup in code execution.
Improvement in code readability Over-indented code lines were addressed to improve the script's readability.
Updated call & import methods in index.js The call to checkIfUserIsInOffice, as well as the import statement for createSendGrid command, have been modified to enable the new check in the index.js.
Command modification for enhanced function implementation The action for .command("sendgrid create") in index.js has been modified to use checkIfUserIsInOffice instead of createSendGrid. This helps ensure the user is in the office before allowing the "create" command to run.

These changes are designed to improve the software's reliability, troubleshoot ability, and user experience, especially in terms of network stability and location-based operation controls.

Dev's Notes

Short text about what has been done in this feature branch. Copy the same info that has been added to CHANGELOG.md

ToDo

[ ] refaktorera mot ett mer funktionellt paradigm
[ ] lägg till funktion för att få möjlighet att stänga av VPN efter skapat sendgridkonto

what-the-diff[bot] commented 8 months ago

PR Summary

Enhanced Functionality in sendgrid.js Several additions have been made to this file for extended functionality. We have new tools (functions) introduced named connectToVPN and proceedWithSendGrid. More so, a function that checks if a user is in the office, checkIfUserIsInOffice, is now being exported from this file. Meanwhile, the existing createSendGrid function has been updated to involve the newly created checkIfUserIsInOffice function.
Revisions in index.js Important updates have been made to how we are utilizing the sendgrid.js file tools within index.js. The createSendGrid usage has been replaced with the checkIfUserIsInOffice function. This shows a shift in the action for the sendgrid create command, which now involves checking if a user is in the office rather than directly creating a SendGrid instance.

lissmeister commented 7 months ago

Looking good, but have a look at listing the available vpn connections and allow the user to select the right one from a list.

scutil --nc list | grep -o '"[^"]*"'

crispyabsurdist commented 7 months ago

Looking good, but have a look at listing the available vpn connections and allow the user to select the right one from a list.

scutil --nc list | grep -o '"[^"]*"'

implemented!

triggerfishab / lisa-cli