AWS_LAMBDA_RUNTIME_API is hardcoded and can't be overwritten

triggermesh / aws-custom-runtime

Knative Function Using the AWS Lambda Runtime API

https://triggermesh.com

Apache License 2.0

46 stars 14 forks source link

AWS_LAMBDA_RUNTIME_API is hardcoded and can't be overwritten #14

Closed Hi-Fi closed 4 years ago

Hi-Fi commented 4 years ago

If InternalAPIport is changed to something else than 80 (which is the default value), functions are not starting because AWS_LAMBDA_RUNTIME_API is hardcoded to be just 127.0.0.1.

AWS_LAMBDA_RUNTIME_API should probably be 127.0.0.1:<InternalAPIport>?

Relates to triggermesh/knative-lambda-runtime#48

tzununbekov commented 4 years ago

@Hi-Fi hey, is it possible for you to check if changes in #15 solve the problem or you need to have the prebuilt KLR image to test it?

Hi-Fi commented 4 years ago

Seems to be working fine. Replaced in go example Dockerfile's go get github.com/triggermesh/aws-custom-runtimewith GO111MODULE=on go get github.com/triggermesh/aws-custom-runtime@ef74027b321f3b1df486614ebfb64552c69f8506.