triggermesh / aws-event-sources

Knative event sources for AWS services
Apache License 2.0
60 stars 14 forks source link

pi: Rename metricQueries to metrics #333

Closed antoineco closed 3 years ago

antoineco commented 3 years ago

Closes #284

tl;dr: _What we call a "metrics_query" is not the same things as the "metricquery" defined by Amazon.

As discussed in the referenced issue, this source only allows users to request a list of metrics, without the GroupBy and Filter attributes available inside Amazon's actual MetricQueries.

In a effort to keep the vocabulary of our APIs as accurate as possible, I suggest we rename

metric_queries: []

to

metrics: []