Refactor awsiot source to use Knative's adapter package

triggermesh / aws-event-sources

Knative event sources for AWS services

Apache License 2.0

60 stars 14 forks source link

Refactor awsiot source to use Knative's adapter package #83

Closed antoineco closed 3 years ago

antoineco commented 4 years ago

Should include necessary changes to Makefile, CI conf, and docs.

To be decided: is it worth rewriting from Python to Go?

antoineco commented 3 years ago

@sebgoa it seems like the AWS IoT source remained at the stage of prototype. Right now it's just a piece of Python code lying in its own directory, disconnected from the rest. It's not even mentioned in the README.

I think it's time to decide whether we want to:

Commit to supporting AWS IoT properly and write a source in Go which is part of our standard release flow
Remove that code

Any thoughts?

benmoss commented 3 years ago

removed in https://github.com/triggermesh/aws-event-sources/pull/300