search

triggermesh / charts

Charts for TriggerMesh Deployments
Apache License 2.0
3 stars 6 forks source link

Automate installation, primarily for e2e setup #6

Closed solsson closed 6 years ago

solsson commented 6 years ago

Supercedes https://github.com/triggermesh/charts/pull/5

The installer concept is idempotent. I've used it quite heavily in e2e, but only on minikube. I've also not had a chance to test the new cloudbuild step, but I can do that after merge.

sebgoa commented 6 years ago

the biggest question with a change like this is: will this affect @cab105 gitlab installs ?

solsson commented 6 years ago

I hope that the version bump means that any existing 0.1.2 tarball is unaffected. If we depend on building that 0.1.2 repeatably however we should probably tag the charts repo with v0.1.2 now.

cab105 commented 6 years ago

We should be okay since I believe the chart version is still published as 0.1.2, however since I'm still in the process of working on my other PR, I'd say lets merge it now and iron out the kinks.

solsson commented 6 years ago

Great. I don't have merge access though. I suggest we tag v0.1.2 prior to merge.

solsson commented 6 years ago

@sebgoa Can we tag v0.1.2 and merge this now after today's Gitlab demo?

cab105 commented 6 years ago

The one question I do have is if this will get pushed to the GCS instance being hosted currently?

solsson commented 6 years ago

Apparently $PROJECT_ID decides what gets pushed, both to GCS buckets as before (but with a bumped version in filename) and now to docker registry. I don't know enough about Cloud Build to understand how this runs. I've seen that gcloud config set project affects the URLs we push to.

cab105 commented 6 years ago

Okay cool. Did observe that and have updated the work on the other project accordingly.