search

triggermesh / tm

TriggerMesh CLI to work with knative objects
https://triggermesh.com
Apache License 2.0
84 stars 15 forks source link

Deploy should not create a new service #141

Closed sebgoa closed 4 years ago

sebgoa commented 5 years ago

When we create multiple times we actually create a new service and we do not do an update.

We should find a way to do an apply to the service definition so that we get a new revision and can rollback.

tzununbekov commented 4 years ago

Not sure if I get it right, but we're updating service if the one with the same name already exist: https://github.com/triggermesh/tm/blob/master/pkg/resources/service/create.go#L160-L180

If it doesn't work or it should work differently, please let me know in detail