triggermesh / tm

TriggerMesh CLI to work with knative objects
https://triggermesh.com
Apache License 2.0
84 stars 15 forks source link

Add Description for Push Command #151

Closed danielhelfand closed 4 years ago

danielhelfand commented 4 years ago

tm push is the only command missing a description:

Triggermesh CLI

Usage:
  tm [command]

Available Commands:
  delete      Delete knative resource
  deploy      Deploy knative resource
  generate    Generate sample project
  get         Retrieve resources from k8s cluster
  help        Help about any command
  push        
  set         Set resource parameters
  version     Print the version number of tm CLI

Flags:
      --config string          k8s config file
  -d, --debug                  Enable debug output
      --dry                    Do not create k8s objects, just print its structure
  -h, --help                   help for tm
  -n, --namespace string       User namespace
  -o, --output string          Output format
      --registry-host string   Docker registry host address (default "knative.registry.svc.cluster.local")
      --wait                   Wait for the operation to complete

Use "tm [command] --help" for more information about a command.

Adding Short: tm push description here would be nice to have.

tzununbekov commented 4 years ago

Hi @danielhelfand, thanks for reporting this issue We replaced our custom components with tekton triggers in tm push internals recently and it still was in sort of testing mode. In my opinion, although tm push command based on tekton triggers seems to be a better option, old push command provides better user experience with less number of "moving" parts:

We'll figure out which implementation is more suitable for us and merge it into upstream

danielhelfand commented 4 years ago

@tzununbekov Thanks for the detailed breakdown. Will keep an eye out for the updates, and look forward to seeing which approach makes it upstream.

tzununbekov commented 4 years ago

So, the transceiver branch has been merged into the upstream, documentation updated Closing issue, @danielhelfand feel free to reopen it if you have any additional questions