Closed NikhilSharmaWe closed 1 year ago
Thank you, @NikhilSharmaWe! Do you think it is possible to also interrupt tmctl watch
command that remains hanging after wiretap container removed? Leaving it active may create a wrong impression for users.
@tzununbekov I have already tried running TMCTL_GENERATE_DOCS=true go run main.go
for updating the docs but I am getting these error for multiple packages:
../../../pkg/mod/github.com/cloudevents/sdk-go/v2@v2.14.0/alias.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/docker/docker@v23.0.6+incompatible/errdefs/defs.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/triggermesh@v1.25.0/pkg/apis/common/v1alpha1/aws_types.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/triggermesh@v1.25.0/pkg/apis/extensions/v1alpha1/deepcopy_generated.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/triggermesh@v1.25.0/pkg/apis/flow/v1alpha1/common_lifecycle.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/triggermesh@v1.25.0/pkg/apis/sources/v1alpha1/awscloudwatch_lifecycle.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/triggermesh@v1.25.0/pkg/apis/targets/v1alpha1/aws_comprehend_lifecycle.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/triggermesh@v1.25.0/pkg/extensions/reconciler/function/adapter.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/triggermesh@v1.25.0/pkg/flow/reconciler/jqtransformation/adapter.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/triggermesh@v1.25.0/pkg/flow/reconciler/transformation/adapter.go:1:1: expected 'package', found 'EOF'
../../../pkg/mod/github.com/triggermesh/triggermesh@v1.25.0/pkg/flow/reconciler/xmltojsontransformation/adapter.go:1:1: expected 'package', found 'EOF'
even after go get -u ./...
Should I update the docs manually?
That's weird, I just tested it on your branch and it worked fine. Yes, you can batch update it:
- --version string TriggerMesh components version. (default "v1.25.0")
+ --version string TriggerMesh components version. (default "v1.25.1")
Updated the docs
Description
This PR adds changes to clean up the wiretap container specific to a broker when
tmctl stop
is used to stop a broker container.Motivation
Fixes: #205