triishaa / pe

0 stars 0 forks source link

Should we just assign participants with one study group? #13

Open triishaa opened 1 week ago

triishaa commented 1 week ago

Should the assign command allow just one KEYWORD as input for the assign command?

I tried to use an assign command with just one parameter. It assigned all the participants in ResearchRoster with the same study group. Should that be allowed? Isnt a study divided between control group and non-control group.

Maybe shouldnt allow just one keyword for assign

soc-pe-bot commented 5 days ago

Team's Response

Thanks for pointing out!

When one uses the assign feature with only one tag, essentially all displayed participants gets assigned into the same group. Technically speaking, this is intended behavior, since the app is simply told to 'randomly' assign participants into one study group.

The main use of the assign feature is to randomly assign participants into multiple study groups. In the case of only one study group being provided, the 'randomizing' effect isn't as clear as using assign with multiple study groups, making it seem a bit out of place.

However, we have allowed this functionality to exist to allow for more flexibility for group assignment. It would be extra clutter to have an additional command specifically for assigning participants to just one group.

As such, we are accepting the issue as a low-severity not-in-scope suggestion!

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inconsistent behaviour of assign command

I think the assign command is slightly unclear in its purpose. In the description given in the user guide, it states that the command assigns persons in the "displayed list" randomly to the given Study Groups. But in the example, find g/M followed by assign Male-Group assigns every male in the address book to Male-Group study group. It is rather confusing why this is allowed, since the purpose of the assign command, in its description is stated to assign contacts randomly. find g/M followed by assign Male-Group does not actually produce the specified behaviour of randomly assigning the contacts in the "displayed list" to the study group, as it assigns all contacts not at random.

Perhaps either the documentation could be more clear and should accurately document the behaviour of the assign command, or, for the assign command to stick to its described functionality of randomly assigning persons in the displayed list, assigning all participants in a filtered list of contacts should be done by a separate command.


[original: nus-cs2103-AY2425S1/pe-interim#2691] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for pointing out!

When one uses the assign feature with only one tag, essentially all displayed participants gets assigned into the same group. Technically speaking, this is intended behavior, since the app is simply told to 'randomly' assign participants into one study group.

The main use of the assign feature is to randomly assign participants into multiple study groups. In the case of only one study group being provided, the 'randomizing' effect isn't as clear as using assign with multiple study groups, making it seem a bit out of place.

However, we have allowed this functionality to exist to allow for more flexibility for group assignment. It would be extra clutter to have an additional command specifically for assigning participants to just one group.

As such, we are accepting the issue as a low-severity not-in-scope suggestion!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]